ianvs icon indicating copy to clipboard operation
ianvs copied to clipboard

add Impl for llm edge benchmark suite

Open XueSongTap opened this issue 1 year ago • 1 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

add Impl for llm edge benchmark suite

Which issue(s) this PR fixes:

https://github.com/kubeedge/ianvs/pull/127

XueSongTap avatar Sep 24 '24 14:09 XueSongTap

@hsj576 Could you please review this PR? I've made several documentation and configuration updates:

  • Comment cleanup in basemodel.py
  • Configuration parameter adjustments
  • Documentation improvements in README, including remove chinese part

Here's screenshot of the benchmark : image image

The results show the changes are working as expected,

Let me know if you need any additional information or clarification.

XueSongTap avatar Oct 26 '24 07:10 XueSongTap

@MooreZheng I have already addressed this concern by squashing all commits into a single commit using rebase. The changes are now consolidated into one cohesive commit for better maintenance and clearer history. Please review the updated changes.

XueSongTap avatar Oct 28 '24 14:10 XueSongTap

/lgtm

MooreZheng avatar Oct 29 '24 16:10 MooreZheng

@XueSongTap might need one more review from @hsj576

MooreZheng avatar Oct 29 '24 16:10 MooreZheng

/lgtm

hsj576 avatar Oct 30 '24 02:10 hsj576

/lgtm

CreativityH avatar Oct 30 '24 02:10 CreativityH

@CreativityH: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubeedge-bot avatar Oct 30 '24 02:10 kubeedge-bot

@MooreZheng hi, i've changed print() using logger. Could you please review this PR? Let me know if you need any additional information or clarification.

XueSongTap avatar Oct 30 '24 14:10 XueSongTap

/lgtm

MooreZheng avatar Oct 30 '24 14:10 MooreZheng

/approve

MooreZheng avatar Oct 30 '24 14:10 MooreZheng

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubeedge-bot avatar Oct 30 '24 14:10 kubeedge-bot