kubedl
kubedl copied to clipboard
[WIP] feat: enable data caching cross jobs
Signed-off-by: Zhijun Chen [email protected]
Ⅰ. Describe what this PR does
This PR decouples cacheBackend from jobs and makes cacheBackend can be reused in different jobs.
II. Does this pull request fix one issue?
#252
III. Special notes for reviewers if any.
In progress, update doc & unit testing later.
- [x] code
- [ ] unit testing
- [ ] document
Codecov Report
Merging #263 (7f7769e) into master (7c2c969) will increase coverage by
0.64%
. The diff coverage is34.40%
.
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 29.43% 30.07% +0.64%
==========================================
Files 89 89
Lines 6193 6260 +67
==========================================
+ Hits 1823 1883 +60
- Misses 4108 4115 +7
Partials 262 262
Flag | Coverage Δ | |
---|---|---|
unittests | 30.07% <34.40%> (+0.64%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/job_controller/job.go | 24.84% <0.00%> (-0.32%) |
:arrow_down: |
pkg/job_controller/job_controller.go | 37.50% <35.48%> (+26.38%) |
:arrow_up: |
controllers/cache/cachebackend_controller.go | 41.30% <40.38%> (+3.20%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@zjchenn hi zjchenn, thanks for your contribution! you may design & implement unit testing in next stage of work.
/cc @SimonCqk
/LGTM