kubedl icon indicating copy to clipboard operation
kubedl copied to clipboard

GetImageConfig should return default configs for the images

Open jian-he opened this issue 3 years ago • 1 comments

Here we can return the default image, instead of return empty image

func (h *KubeDLHandler) GetImageConfig() *ImageConfig {
	cm := &v1.ConfigMap{}
	err := h.client.Get(context.Background(), types.NamespacedName{
		Namespace: constants.KubeDLSystemNamespace,
		Name:      constants.KubeDLConsoleConfig,
	}, cm)
	if err != nil {
		glog.Infof("get image config error: %v", err)
		return &ImageConfig{}
	}

jian-he avatar Jul 21 '21 00:07 jian-he

/assign

Just a suggestion, it would be better that label the issues like other projects.

cbl315 avatar Aug 17 '21 02:08 cbl315