KubeArmor
KubeArmor copied to clipboard
Add controller Health checks
this PR addresses #764 and exposes a healthcheck endpoint for both controllers on port 8081 by default
Hey @s1ntaxe770r,
Can you please make the appropriate chanegs to the yaml files under pkg/KubeArmorHostPolicy
, pkg/KubeArmorPolicy
and deployments/
to include liveness probes.
except that, the pr LGTM.
@achrefbensaad re-review pls?
everything looks in place, except manifests under geeneric should be automatically generated.
- add the heath checks under objects.go
- run make to generate a new manifest under generic folder.
@s1ntaxe770r can you please squash your commits?
Let's wait until all comments are squashed to a single one.
🤔 @nam-jaehyun does this look good now?
Codecov Report
Merging #766 (b92d2cd) into main (804b690) will increase coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 39.90% 39.95% +0.05%
==========================================
Files 30 30
Lines 9285 9285
==========================================
+ Hits 3705 3710 +5
+ Misses 5092 5087 -5
Partials 488 488
Impacted Files | Coverage Δ | |
---|---|---|
KubeArmor/monitor/syscallParser.go | 62.53% <0.00%> (-0.76%) |
:arrow_down: |
KubeArmor/feeder/policyMatcher.go | 49.42% <0.00%> (+0.83%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.