KubeArmor icon indicating copy to clipboard operation
KubeArmor copied to clipboard

Add controller Health checks

Open s1ntaxe770r opened this issue 2 years ago • 6 comments

this PR addresses #764 and exposes a healthcheck endpoint for both controllers on port 8081 by default

s1ntaxe770r avatar Jul 09 '22 19:07 s1ntaxe770r

Hey @s1ntaxe770r, Can you please make the appropriate chanegs to the yaml files under pkg/KubeArmorHostPolicy , pkg/KubeArmorPolicy and deployments/ to include liveness probes. except that, the pr LGTM.

achrefbensaad avatar Jul 11 '22 06:07 achrefbensaad

@achrefbensaad re-review pls?

s1ntaxe770r avatar Jul 16 '22 13:07 s1ntaxe770r

everything looks in place, except manifests under geeneric should be automatically generated.

  • add the heath checks under objects.go
  • run make to generate a new manifest under generic folder.

achrefbensaad avatar Jul 17 '22 09:07 achrefbensaad

@s1ntaxe770r can you please squash your commits?

achrefbensaad avatar Jul 18 '22 04:07 achrefbensaad

Let's wait until all comments are squashed to a single one.

nam-jaehyun avatar Aug 11 '22 04:08 nam-jaehyun

🤔 @nam-jaehyun does this look good now?

s1ntaxe770r avatar Aug 11 '22 18:08 s1ntaxe770r

Codecov Report

Merging #766 (b92d2cd) into main (804b690) will increase coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   39.90%   39.95%   +0.05%     
==========================================
  Files          30       30              
  Lines        9285     9285              
==========================================
+ Hits         3705     3710       +5     
+ Misses       5092     5087       -5     
  Partials      488      488              
Impacted Files Coverage Δ
KubeArmor/monitor/syscallParser.go 62.53% <0.00%> (-0.76%) :arrow_down:
KubeArmor/feeder/policyMatcher.go 49.42% <0.00%> (+0.83%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 18 '22 05:08 codecov-commenter