KubeArmor
KubeArmor copied to clipboard
kubearmor
Add Github action to check if each commit is compiling
Feature Request
A PR could be made up of multiple commits. We expect every commit to be self-sufficient i.e., solves a problem and is compilable/testable/revertable. We want the ability to check/ensure that every commit within a PR is compilable (and later testable). This way if needed we can revert individual commits. Further we want the ability to handle git-bisect to figure out which commit might have broken the tests.
Thus the requirement is that if a PR contains multiple commits, the make has to be done at every individual commit level.
@Ankurk99 had handled the same for cilium repo in https://github.com/cilium/cilium/pull/15659 (for ref). (We already have PR-level make and tests for Kubearmor)
Tasks
- [ ] Compile/handle ci-go workflow for every commit
- [ ] Handle basic tests for every commit (We can discuss what basic tests would mean here)
Here is the reference GH workflow from cilium.
- [ ] Handle basic tests for every commit (We can discuss what basic tests would mean here)
Hey @nyrahul, I'd like to know about the tests that we're supposed to handle within the CI.
@h3llix we already check if the new code is compilable during ci-test. can you check if the ci-test contains what you think?
@nam-jaehyun https://github.com/kubearmor/KubeArmor/blob/main/tests/test-scenarios-github.sh#L155 We run the test here. But I don't think we run and test it for individual commits.
Just curiosity. Does the GitHub Action work per commit? or... Does it work per PR? I mean the point of view of KubeArmor repo (not a personal repo for development)
Just curiosity. Does the GitHub Action work per commit? or... Does it work per PR? I mean the point of view of KubeArmor repo (not a personal repo for development)
The GH action is fired at PR level push event. But inside the event, we can iterate through the commits and build/test for each commit.
