KubeArmor icon indicating copy to clipboard operation
KubeArmor copied to clipboard

fix(ci): coverage report generation for k8s_env tests

Open tesla59 opened this issue 9 months ago • 2 comments

Purpose of PR?:

Fixes https://github.com/kubearmor/KubeArmor/issues/1758

Does this PR introduce a breaking change? No, it changes Ci step

If the changes in this PR are manually verified, list down the scenarios covered:: N/A

Additional information for reviewer? : The main purpose of gover is to concatenate multiple cover profiles into a single file. We dont need to do this as ginkgo already stored the cover profile in a single file (by default coverprofile.out).

The PR adds a flag in ginkgo test command to generate test profile for every package in the github.com/kubearmor/KubeArmor/tests . The reason to use full path is a bug in ginkgo when using relative path. It is supposedly fixed but using the relative path didnt work in our case (ref: https://github.com/onsi/ginkgo/issues/1161#issuecomment-1462585824)

Checklist:

  • [x] Bug fix. Fixes https://github.com/kubearmor/KubeArmor/issues/1758
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update
  • [x] PR Title follows the convention of <type>(<scope>): <subject>
  • [ ] Commit has unit tests
  • [ ] Commit has integration tests

tesla59 avatar May 20 '24 21:05 tesla59