KubeArmor icon indicating copy to clipboard operation
KubeArmor copied to clipboard

Updated the OS version from Ubuntu-20.04 to matrix containing Ubuntu-22.04

Open Srijan-SS02 opened this issue 1 year ago • 5 comments

Purpose of PR?:

Fixes #1433

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? : Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • [x] Bug fix. Fixes #
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update
  • [ ] PR Title follows the convention of <type>(<scope>): <subject>
  • [ ] Commit has unit tests
  • [ ] Commit has integration tests

Srijan-SS02 avatar Nov 17 '23 19:11 Srijan-SS02

@daemon1024 @ShubhamTatvamasi please review

Srijan-SS02 avatar Nov 17 '23 19:11 Srijan-SS02

@Srijan-SS02 There's some issue with crio tests on 22.04. We would need to try on a Ubuntu 22.04 machine, reproduce and fix the problem.

We cannot merge this PR till then. Would you like to take it up?

daemon1024 avatar Nov 29 '23 11:11 daemon1024

@Srijan-SS02 There's some issue with crio tests on 22.04. We would need to try on a Ubuntu 22.04 machine, reproduce and fix the problem.

We cannot merge this PR till then. Would you like to take it up?

Yup sure, but will definitely need your guidance on that. Really interested to work on this!

Srijan-SS02 avatar Nov 29 '23 11:11 Srijan-SS02

@Srijan-SS02 great to know that.

The steps would be something in line of.

Create a Ubuntu 22.04 VM. Use install k3s script but with crio variable.

Afair it's something like RUNTIME=crio ./path/to/install_k3s.sh

The spelling and casing could be different, you can verify things from the GH Actions workflow itself.

Try deploying KubeArmor on the same. That should be suffice. Because KubeArmor itself fails to install in the CI env.

daemon1024 avatar Nov 29 '23 12:11 daemon1024

@Srijan-SS02 any updates on this?

PrimalPimmy avatar Jan 22 '24 05:01 PrimalPimmy