KubeArmor icon indicating copy to clipboard operation
KubeArmor copied to clipboard

Add Go Report Card Badge to README.md

Open ShubhamTatvamasi opened this issue 2 years ago • 10 comments

https://goreportcard.com

ShubhamTatvamasi avatar Sep 25 '23 09:09 ShubhamTatvamasi

Hello @ShubhamTatvamasi I would like to work on this issue when I go to the https://goreportcard.com/ and generate the report card it gives me the error

MeenuyD avatar Sep 25 '23 12:09 MeenuyD

Hello @ShubhamTatvamasi I would like to work on this issue when I go to the https://goreportcard.com/ and generate the report card it gives me the error

I am aware of this error. Can you please do some research, how can this be fixed?

I was able to add this on my sample repo. https://github.com/ShubhamTatvamasi/gin-key-value-store

ShubhamTatvamasi avatar Sep 25 '23 12:09 ShubhamTatvamasi

sure

MeenuyD avatar Sep 25 '23 15:09 MeenuyD

  • @ShubhamTatvamasi ,i think the error is happening because there is not go file in the root folder. the repo you mentioned above has the go files in the root folder
  • https://github.com/gojp/goreportcard/issues/373

akagami-harsh avatar Oct 13 '23 10:10 akagami-harsh

Do we have any solution for this?

ShubhamTatvamasi avatar Oct 15 '23 00:10 ShubhamTatvamasi

Is this up for work? I wd like to give it a try. @ShubhamTatvamasi

prakrit55 avatar Nov 26 '23 06:11 prakrit55

@ShubhamTatvamasi I have used goreportcard-cli for generating report card by specifying the path to the kubeArmor image I am not able to generate reportcard in their website should we add this report statically or we should look for alternatives?

harisudarsan1 avatar Dec 20 '23 03:12 harisudarsan1

Can we look for ways, why is it that the website cannot generate our report? (It's probably due our repository structure) But it would be best to report to the goreport project that this needs to be looked at and seek guidance from them on how to handle it.

Thanks everyone for putting efforts towards this.

daemon1024 avatar Jan 18 '24 09:01 daemon1024

@daemon1024 We Don't have go.mod file in the root of our project and also we have uppercase module name we need to fix it for generating the report card. as mentioned here I think. But this repo is having upper case module but still it is able to generate report card.

harisudarsan1 avatar Jan 18 '24 11:01 harisudarsan1

@daemon1024 We Don't have go.mod file in the root of our project and also we have uppercase module name we need to fix it for generating the report card. as mentioned here I think. But this repo is having upper case module but still it is able to generate report card.

The go report card is downloading the modules as zip files and testing as of now and it is searching for modules in lower case letters so after downloading it the .go files are not present for example(http://proxy.golang.org/github.com/kubearmor/kubearmor/@v/v1.0.3.zip) if we download this zip and inspect it we cannot find the .go files.

harisudarsan1 avatar Jan 18 '24 11:01 harisudarsan1