k8s-mediaserver-operator
k8s-mediaserver-operator copied to clipboard
kubealex
Draft: Separate Helm Charts
Breaks the helm charts out into individual charts with a superchart pattern.
generally by pulling this branch down it can be used in the same manner it always was via:
helm template k8s-mediaserver ./
When changes are made to the sub charts the changes can be pulled in via:
helm dep update
and in the future we can add a GitHub pages helm index for the charts and reference them via that.
@kubealex I'm leaving this in draft state atm, but I'd love if you could do a brief review to make sure you like the direction and to get your overall feedback.
@kubealex been on hold for the Jellyfin PR https://github.com/kubealex/k8s-mediaserver-operator/pull/72 for a month now.
Want me to just toss this all together?
Think with quick PR reviews I could get this PR done with Jellyfin within a week.
I'll start the work either way. 🙂 Probably have an update by tomorrow.
Got a few minutes not buried under kiddos. Had to modify my current fork slightly, but back into business with Jellyfin.
Will try to clean this up further, and prove that it gens the same stuff. Hopefully then we can just merge this PR all at once to get Jellyfin and individual helm charts.
Jellyfin has been merged @reedjosh, can you double check if this in any way creates any clash?
I will begin cleanup on this branch. Hopefully I'll have a non-draft PR within the next week. : )
@reedjosh Any idea how much cleanup you still want to do? Anywhere I can assist?
@NigelVanHattum I'll try to get back to this sometime soon.
Unfortunately, it will need quite a bit still as the upstream changes will need incorporating and my PR was still not polished even before that.
I do still want this done though, so I'll try to get to it in the next week or so.