metering-operator icon indicating copy to clipboard operation
metering-operator copied to clipboard

The e2e suite doesn't support overriding the metering package name

Open timflannagan opened this issue 4 years ago • 0 comments

When running the e2e suite locally with a non-default (metering-ocp) package name, the e2e suite doesn't have the ability to find or use that value, and instead always uses the default package name.

This could likely be tackled by adding an additional CLI flag and propagating that down to the deployer context structure.

That structure is defined below:

// NewDeployerConfig handles the process of validating inputs before returning
// an initialized Deploy.Config object, or an error if there is any.
func (df *DeployFramework) NewDeployerConfig(
	namespace,
	meteringOperatorImageRepo,
	meteringOperatorImageTag,
	reportingOperatorImageRepo,
	reportingOperatorImageTag,
	catalogSourceName,
	catalogSourceNamespace,
	subscriptionChannel string,
	spec metering.MeteringConfigSpec,
) (*deploy.Config, error) {
        ...
	return &deploy.Config{
		Namespace:              namespace,
		Repo:                   meteringOperatorImageRepo,
		Tag:                    meteringOperatorImageTag,
		Platform:               defaultPlatform,
		DeleteNamespace:        defaultDeleteNamespace,
		DeleteCRB:              defaultDeleteCRB,
		SubscriptionName:       defaultSubscriptionName,
		PackageName:            defaultPackageName,
		CatalogSourceName:      catalogSourceName,
		CatalogSourceNamespace: catalogSourceNamespace,
		Channel:                subscriptionChannel,
		ExtraNamespaceLabels: map[string]string{
			"name": df.NamespacePrefix + "-" + testNamespaceLabel,
		},
		OperatorResources:        df.OperatorResources,
		RunMeteringOperatorLocal: df.RunLocal,
		MeteringConfig:           meteringConfig,
	}, nil
}

timflannagan avatar Jan 21 '21 22:01 timflannagan