simp_le icon indicating copy to clipboard operation
simp_le copied to clipboard

Retain order of domains

Open zx2c4 opened this issue 8 years ago • 3 comments

This ensures that the first domain specified on the command line will be the domain that winds up in the CN field. Otherwise, users have no way of controlling this.

This also supports Python 2.6, which is an improvement over the prior pull request. It also correctly tames pylint for an extremely widespread conditional import pattern.

It should pass all tests on Travis.

Fixes: kuba/simp_le#72 Signed-off-by: Jason A. Donenfeld [email protected]

zx2c4 avatar Feb 28 '16 02:02 zx2c4

This is missing any kind of tests.

kuba avatar Feb 28 '16 15:02 kuba

Okay, now it locally disables for the linter. Good thinking.

I just took a look at how you're implementing the test suite. I can struggle and grunt to add the tests to the test suite here, and in the end I'm sure it won't fit your criteria for inclusion. Would you rather we do some iterations of me struggling, or could you just add this in five minutes yourself?

zx2c4 avatar Feb 28 '16 16:02 zx2c4

I could try to write tests, but not in foreseeable future - unfortunately I'm extremely busy atm. If you're fine with waiting a couple of weeks before this get merged, then OK...

kuba avatar Feb 28 '16 17:02 kuba