bitpocket slave's symlinks deleted on sync

I've been using bitpocket for a while with great success. I can't seem to track down why soft links created on my slave machine are deleted when I run a sync. I saw a note referencing a missing RSYNC_OPTS bug so I downloaded the most recent version to test if it fixes the problem. It does not.

Mar 18 '14 18:03 jordan-stone

I have just merged mentioned PR. Please check latest version from master.

Mar 18 '14 19:03 ku1ik

Thanks. I just checked the latest version which does now behave differently. Specifically, now when I set the RSYNC_OPTS="-L" parameter my slave-side soft links aren't deleted. However, I'd really prefer to have RSYNC_OPTS="-l", so that my links are copied as links, not dereferenced. When I set RSYNC_OPTS="-l" in the config file, bitpocket returns to the old behavior of deleting the links on the slave side.

Mar 18 '14 21:03 jordan-stone

I think I've tracked down what's going on. When tree-current is being built with the rsync call on lines 128 and 129, even though rsync is called with the -a switch, the following grep selects only normal files and directories. So, unless the -L switch is set, new links never make it into tree-current and are deleted during the fetch.

One change I can think of which could solve this problem is the following: change the grep call from grep "^-|^d" to grep "^-|^d|^l" and then append an additional pipe to another sed call to get rid of the arrows associated with links, something like sed "s:->.*::"

I don't think I completely understand what all the implications of such a change would be, or if there is some reason why this would be a bad idea. Any thoughts?

Mar 18 '14 23:03 jordan-stone

@jordan-stone I believe this was addressed in 33b61a854a68d7e39125a2474fa22ea4d1c40ad7, would you mind pulling and trying with the new codebase?

Aug 23 '17 21:08 greezybacon