evans icon indicating copy to clipboard operation
evans copied to clipboard

add support for unix domain sockets

Open flokli opened this issue 2 years ago • 2 comments

grpc.NewClient already supports connecting to unix domain sockets, and accepts a string anyways.

As a quick fix, detect the address starting with unix:// and don't add the port.

In the long term, we might want to deprecate host and port cmdline args in favor of a single address arg.

Fixes #654.

flokli avatar Oct 08 '23 09:10 flokli

Codecov Report

Merging #680 (55d7e7a) into master (d1bc03a) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   77.10%   77.13%   +0.02%     
==========================================
  Files          57       57              
  Lines        3910     3915       +5     
==========================================
+ Hits         3015     3020       +5     
  Misses        647      647              
  Partials      248      248              

codecov[bot] avatar Oct 08 '23 09:10 codecov[bot]

@ktr0731 poke ;-)

flokli avatar Nov 06 '23 19:11 flokli