ktor icon indicating copy to clipboard operation
ktor copied to clipboard

KTOR-7482 Use default JDK for running tests on CI

Open osipxd opened this issue 1 year ago • 2 comments

Subsystem Tests infrastructure

Motivation As part of KTOR-7482, we need to run tests against different JDK versions.

Solution Use the JDK from JAVA_HOME to run tests on CI.

osipxd avatar Sep 25 '24 07:09 osipxd

There seems to be some problems in the TLS package - we got an out-dated ECDH curve java.security.ProviderException: Curve not supported: secp128r1 (1.3.132.0.28) and some rogue reflection java.lang.reflect.InaccessibleObjectException: Unable to make private static java.time.Instant java.time.Instant.create(long,int) accessible: module java.base does not "opens java.time" to unnamed module @5b8bc155

You also seem to have unlocked a consistent failure in testHeaderIsTooLong(), so that's good 😄

bjhham avatar Sep 26 '24 15:09 bjhham

Yes, finally these builds against different Java versions found something :)

osipxd avatar Sep 26 '24 15:09 osipxd

@bjhham, finally I've fixed this PR. After some tries I didn't manage to fix testHeaderIsTooLong, so I disabled it and created a task to fix it later:

  • KTOR-7811 Flaky test: SustainabilityTestSuite.testHeaderIsTooLong

osipxd avatar Nov 19 '24 15:11 osipxd

Looks like there's just one test being a nuisance here io.ktor.tests.server.tomcat.jakarta.TomcatHttpServerCommonTest.

Might need to ignore it idk.

bjhham avatar Nov 22 '24 07:11 bjhham

testHeadRequest requires investigation

e5l avatar Nov 22 '24 08:11 e5l

@osipxd, could you put @Ignore on this test in your branch? I'm investigating it in the separate one

e5l avatar Nov 22 '24 08:11 e5l