KTOR-7048: Support parameters in Resources url inside the path

Open hfhbd opened this issue 1 year ago • 6 comments

Subsystem Client, Server, shared resources

Motivation KTOR-7048: Resources url builder does not replaces parameters inside the path

Solution Use a regex to replace the placeholder url with the actual values

May 30 '24 15:05 hfhbd

It looks like the resource tests are failing. Could you check?

May 31 '24 17:05 e5l

Can you rerun the CI?

Jun 06 '24 10:06 hfhbd

Sure, sorry for the delay

Jun 21 '24 07:06 e5l

Seems there's a test failure in ResourcesTest.testEncodesParameters() 🔴

Sep 11 '24 12:09 bjhham

@hfhbd, would you like to rebase this PR and fix tests?

Nov 20 '24 15:11 osipxd

@osipxd Yes, will do it, but I also noticed the failing test requires a little rework because I didn't handle the test case.

Nov 25 '24 13:11 hfhbd