Kruno Tomola Fabro

Results 31 comments of Kruno Tomola Fabro

@jszwedko this is ready for review. cc. @sim0nx

That makes sense. Then I'll change it to use `Buffer`.

@tobz I've changed it use `Buffer` so feel free to check it. As a note, there is a bug I'm currently debugging that's related to this PR. When a retry...

@tobz @bruceg this is ready for review. Regarding the error `version conflict, document already exists` it's a transient error on the side of Elasticsearch. There is a report of it...

@tobz > it sounds like this already a possible issue to hit with Vector without this PR? Indeed: * https://github.com/vectordotdev/vector/issues/2968 * https://discord.com/channels/742820443487993987/746070591097798688/775478035738525707 * https://github.com/vectordotdev/vector/issues/10146 * https://github.com/vectordotdev/vector/issues/11359 > does this PR...

This `version conflict` can happen without using distribution. It's possible to trigger this error with a single endpoint. So the only thing distribution changes is that it can increases throughput...

The 404s aren't surprising. It seams the source didn't register that the container was stopped so it's retrying to fetch it's logs.

Probably, but we should have been notified that the container was stopped so this is some bug on our side in tracking the state of containers that we picked up...

@tobz @bruceg this is ready for review.