koji-ansible icon indicating copy to clipboard operation
koji-ansible copied to clipboard

Remove inheritance with the same name, too

Open ahills opened this issue 5 years ago • 3 comments

Koji won't allow a tag's parents to include two of the same name nor priority, so remove matches for either, instead of just priority. This will allow changing a parent's priority when another parent already has that priority, by removing both inheritance links before setting the desired one.

It also allows removing inheritance link by either parent tag name or priority, as well as both (exact match).

ahills avatar Aug 27 '19 14:08 ahills

I will test this tomorrow

ktdreyer avatar Oct 15 '19 23:10 ktdreyer

Rebased on #68, improved commit message and documentation, and expanded test coverage.

ahills avatar Nov 20 '19 07:11 ahills

I think this is a lot easier to review now, thanks. If you rebase on master again, it'll be easier to see the single commit.

tests/integration/koji_tag_inheritance/update-1.yml fails now: xmlrpc.client.Fault: <Fault 1000: 'Changes should not contain duplicated parent_id(5)'>

We need more integration tests for this behavior, so I added them as a pull request to your branch: https://github.com/ahills/koji-ansible/pull/1

ktdreyer avatar Nov 20 '19 21:11 ktdreyer