koji-ansible
koji-ansible copied to clipboard
Remove inheritance with the same name, too
Koji won't allow a tag's parents to include two of the same name nor priority, so remove matches for either, instead of just priority. This will allow changing a parent's priority when another parent already has that priority, by removing both inheritance links before setting the desired one.
It also allows removing inheritance link by either parent tag name or priority, as well as both (exact match).
I will test this tomorrow
Rebased on #68, improved commit message and documentation, and expanded test coverage.
I think this is a lot easier to review now, thanks. If you rebase on master again, it'll be easier to see the single commit.
tests/integration/koji_tag_inheritance/update-1.yml
fails now:
xmlrpc.client.Fault: <Fault 1000: 'Changes should not contain duplicated parent_id(5)'>
We need more integration tests for this behavior, so I added them as a pull request to your branch: https://github.com/ahills/koji-ansible/pull/1