netmiko icon indicating copy to clipboard operation
netmiko copied to clipboard

Dell SONiC File Transfer implementation

Open aravindmani-1 opened this issue 2 years ago • 9 comments

What i did:

  • To fix https://github.com/ktbyers/netmiko/issues/3102

How i did:

  • Modified the code to support Dell SONiC SCP File Transfer implementation.

How to verify it:

    ./dellsonic_test.sh
    Starting tests...good luck:
    Dell SONiC Networking
    ==================================================================================== test session starts ====================================================================================
    platform linux -- Python 3.8.10, pytest-7.2.0, pluggy-1.0.0 -- /usr/bin/python3
    cachedir: .pytest_cache
    rootdir: /home/am1/netmiko, configfile: setup.cfg
    plugins: cov-4.0.0, pylama-8.4.1, pythonpath-0.7.4, json-0.4.0
    collected 25 items
    
    test_netmiko_show.py::test_failed_key SKIPPED (Not using SSH-keys)                                                                                                                    [  4%]
    test_netmiko_show.py::test_disable_paging PASSED                                                                                                                                      [  8%]
    test_netmiko_show.py::test_terminal_width PASSED                                                                                                                                      [ 12%]
    test_netmiko_show.py::test_ssh_connect PASSED                                                                                                                                         [ 16%]
    test_netmiko_show.py::test_ssh_connect_cm PASSED                                                                                                                                      [ 20%]
    test_netmiko_show.py::test_send_command_timing PASSED                                                                                                                                 [ 24%]
    test_netmiko_show.py::test_send_command_timing_no_cmd_verify SKIPPED                                                                                                                  [ 28%]
    test_netmiko_show.py::test_send_command PASSED                                                                                                                                        [ 32%]
    test_netmiko_show.py::test_send_command_no_cmd_verify SKIPPED                                                                                                                         [ 36%]
    test_netmiko_show.py::test_complete_on_space_disabled SKIPPED                                                                                                                         [ 40%]
    test_netmiko_show.py::test_send_command_textfsm SKIPPED (TextFSM/ntc-templates not supported on this platform)                                                                        [ 44%]
    test_netmiko_show.py::test_send_command_ttp SKIPPED (TTP template not existing for this platform)                                                                                     [ 48%]
    test_netmiko_show.py::test_send_command_genie SKIPPED (Genie not supported on this platform)                                                                                          [ 52%]
    test_netmiko_show.py::test_send_multiline_timing SKIPPED                                                                                                                              [ 56%]
    test_netmiko_show.py::test_send_multiline SKIPPED                                                                                                                                     [ 60%]
    test_netmiko_show.py::test_send_multiline_prompt SKIPPED                                                                                                                              [ 64%]
    test_netmiko_show.py::test_send_multiline_simple SKIPPED                                                                                                                              [ 68%]
    test_netmiko_show.py::test_base_prompt PASSED                                                                                                                                         [ 72%]
    test_netmiko_show.py::test_strip_prompt PASSED                                                                                                                                        [ 76%]
    test_netmiko_show.py::test_strip_command PASSED                                                                                                                                       [ 80%]
    test_netmiko_show.py::test_normalize_linefeeds PASSED                                                                                                                                 [ 84%]
    test_netmiko_show.py::test_clear_buffer PASSED                                                                                                                                        [ 88%]
    test_netmiko_show.py::test_enable_mode PASSED                                                                                                                                         [ 92%]
    test_netmiko_show.py::test_disconnect PASSED                                                                                                                                          [ 96%]
    test_netmiko_show.py::test_disconnect_no_enable SKIPPED                                                                                                                               [100%]
    
    ================================================================================== short test summary info ==================================================================================
    SKIPPED [1] test_netmiko_show.py:25: Not using SSH-keys
    SKIPPED [1] test_netmiko_show.py:88: Skipped
    SKIPPED [1] test_netmiko_show.py:106: Skipped
    SKIPPED [1] test_netmiko_show.py:128: Skipped
    SKIPPED [1] test_netmiko_show.py:149: TextFSM/ntc-templates not supported on this platform
    SKIPPED [1] test_netmiko_show.py:171: TTP template not existing for this platform
    SKIPPED [1] test_netmiko_show.py:211: Genie not supported on this platform
    SKIPPED [1] test_netmiko_show.py:231: Skipped
    SKIPPED [1] test_netmiko_show.py:247: Skipped
    SKIPPED [1] test_netmiko_show.py:272: Skipped
    SKIPPED [1] test_netmiko_show.py:296: Skipped
    SKIPPED [1] test_netmiko_show.py:401: Skipped
    ============================================================================== 13 passed, 12 skipped in 50.03s ==============================================================================
    ==================================================================================== test session starts ====================================================================================
    platform linux -- Python 3.8.10, pytest-7.2.0, pluggy-1.0.0 -- /usr/bin/python3
    cachedir: .pytest_cache
    rootdir: /home/am1/netmiko, configfile: setup.cfg
    plugins: cov-4.0.0, pylama-8.4.1, pythonpath-0.7.4, json-0.4.0
    collected 13 items
    
    test_netmiko_config.py::test_ssh_connect PASSED                                                                                                                                       [  7%]
    test_netmiko_config.py::test_enable_mode PASSED                                                                                                                                       [ 15%]
    test_netmiko_config.py::test_config_mode PASSED                                                                                                                                       [ 23%]
    test_netmiko_config.py::test_exit_config_mode PASSED                                                                                                                                  [ 30%]
    test_netmiko_config.py::test_config_set PASSED                                                                                                                                        [ 38%]
    test_netmiko_config.py::test_config_set_generator PASSED                                                                                                                              [ 46%]
    test_netmiko_config.py::test_config_set_longcommand PASSED                                                                                                                            [ 53%]
    test_netmiko_config.py::test_config_hostname PASSED                                                                                                                                   [ 61%]
    test_netmiko_config.py::test_config_from_file SKIPPED                                                                                                                                 [ 69%]
    test_netmiko_config.py::test_config_error_pattern SKIPPED (No error_pattern defined.)                                                                                                 [ 76%]
    test_netmiko_config.py::test_banner SKIPPED (No banner defined.)                                                                                                                      [ 84%]
    test_netmiko_config.py::test_global_cmd_verify SKIPPED (No banner defined.)                                                                                                           [ 92%]
    test_netmiko_config.py::test_disconnect PASSED                                                                                                                                        [100%]
    
    ================================================================================== short test summary info ==================================================================================
    SKIPPED [1] test_netmiko_config.py:163: Skipped
    SKIPPED [1] test_netmiko_config.py:175: No error_pattern defined.
    SKIPPED [1] test_netmiko_config.py:209: No banner defined.
    SKIPPED [1] test_netmiko_config.py:242: No banner defined.
    ========================================================================== 9 passed, 4 skipped in 65.57s (0:01:05) ==========================================================================
    ==================================================================================== test session starts ====================================================================================
    platform linux -- Python 3.8.10, pytest-7.2.0, pluggy-1.0.0 -- /usr/bin/python3
    cachedir: .pytest_cache
    rootdir: /home/am1/netmiko, configfile: setup.cfg
    plugins: cov-4.0.0, pylama-8.4.1, pythonpath-0.7.4, json-0.4.0
    collected 12 items
    
    test_netmiko_scp.py::test_scp_put PASSED                                                                                                                                              [  8%]
    test_netmiko_scp.py::test_remote_space_available PASSED                                                                                                                               [ 16%]
    test_netmiko_scp.py::test_local_space_available PASSED                                                                                                                                [ 25%]
    test_netmiko_scp.py::test_verify_space_available_put PASSED                                                                                                                           [ 33%]
    test_netmiko_scp.py::test_remote_file_size PASSED                                                                                                                                     [ 41%]
    test_netmiko_scp.py::test_md5_methods PASSED                                                                                                                                          [ 50%]
    test_netmiko_scp.py::test_disconnect PASSED                                                                                                                                           [ 58%]
    test_netmiko_scp.py::test_verify_space_available_get PASSED                                                                                                                           [ 66%]
    test_netmiko_scp.py::test_scp_get PASSED                                                                                                                                              [ 75%]
    test_netmiko_scp.py::test_md5_methods_get PASSED                                                                                                                                      [ 83%]
    test_netmiko_scp.py::test_disconnect_get PASSED                                                                                                                                       [ 91%]
    test_netmiko_scp.py::test_file_transfer PASSED                                                                                                                                        [100%]
    
    ==================================================================================== 12 passed in 51.14s ====================================================================================

aravindmani-1 avatar Feb 20 '23 05:02 aravindmani-1

@ktbyers Could you please help to run the builds?.

aravindmani-1 avatar Mar 14 '23 06:03 aravindmani-1

@ktbyers Could you please help to run the builds?.

aravindmani-1 avatar May 18 '23 11:05 aravindmani-1

@ktbyers All the checks are passed. Could you please help to review and merge the PR?.

aravindmani-1 avatar May 22 '23 14:05 aravindmani-1

The Branch was out of date and rebase has been done now. @ktbyers Could you please help to run the builds, review and merge the PR?.

aravindmani-1 avatar May 22 '23 15:05 aravindmani-1

@ktbyers Could you please help to review and merge this PR?.

aravindmani-1 avatar Jul 19 '23 08:07 aravindmani-1

@ktbyers Could you please review this PR?.

aravindmani-1 avatar Nov 02 '23 10:11 aravindmani-1

@ktbyers Appreciate your support to review and merge the PR.

skg-net avatar Nov 29 '23 04:11 skg-net

@aravindmani-1 can you please re-sync this branch?

skg-net avatar Nov 29 '23 04:11 skg-net

@aravindmani-1 can you please re-sync this branch?

Done.

aravindmani-1 avatar Nov 29 '23 14:11 aravindmani-1