netmiko icon indicating copy to clipboard operation
netmiko copied to clipboard

make send_config_set available for generic devices

Open Trasmontinho opened this issue 4 years ago • 5 comments

Hi @ktbyers ,

I would like to propose a change on terminal_server. Here is the thing : I'm making some changes on Avocent Equipments (console stuff), I don't think that a plugin for it should be necessary and terminal_server is enough to do it. I've been able to pass send_commands with the terminal_server but send_config_set is failing the exit_config_mode. I basically would like to add methods that will do nothing (as for the f5 driver) to allow the user to send config set.

What do you think about this change ?

Trasmontinho avatar Feb 25 '21 08:02 Trasmontinho

I think I probably disagree with this as I expect the default behavior is Cisco-ios like which is the most common case (so this would change it to a less common case).

In other words, you would break some platforms while using the generic driver and cause some others to work, but the ones we are breaking are more common.

I guess we could put some alternate form of generic that doesn't have a config-mode. I would be open to that.

Regards,

Kirk

ktbyers avatar Feb 25 '21 18:02 ktbyers

I'm ok with that and can propose the pull request.

Which Name would be good to you ? I've seen that generic_ssh is already defined as a platform

Let me know, I'll prepare it.

Trasmontinho avatar Feb 25 '21 18:02 Trasmontinho

@Trasmontinho Are you still interested in working on this?

ktbyers avatar Mar 24 '22 21:03 ktbyers

Hi @ktbyers,

I’ve been quite busy with other subjects. I’ll may reach you next week to define a name for the platform to take this specific case. If you are ok with that.

Sam

Trasmontinho avatar Mar 25 '22 20:03 Trasmontinho

Hi @ktbyers,

If you're ok with it, I propose you "generic_device" as platform name. Is it ok for you ?

Thanks,

Regards, Sam

Trasmontinho avatar Mar 29 '22 10:03 Trasmontinho

I am going to close this as it doesn't seem like we are actively working on it (my fault as it took me so long to respond).

If anyone still wants to work on this, just re-open or create a new pull request.

ktbyers avatar Apr 17 '23 17:04 ktbyers