Kaleb Barrett comments

Results 630 comments of


                                            Kaleb Barrett

Verilator fails test_dff.py example

This is already fixed on master.

Verilator fails test_dff.py example

Oh... totally missed that. Good catch!

Verilator fails test_dff.py example

I don't think we want simulator ifdefs in our examples. I will refactor the example and paste it on the README.

`Force`/`Release` don't work on Verilator

We aren't going to add special code to support Verilator here. I get the need to mark signals as forceable, we already have to do that to make them viewable,...

Fix handling of escaped identifiers containing dots

We have plenty of proprietary testing now. If it works the last thing is to add a newsfrag.

Verilog extended identifiers

Looks like we should handle this somewhere between the GPI (ideal) and the Python handle objects (less than ideal). But we should normalize the names so they are easier to...

Can't store value in array

I see the vpi_put_value on the signal and the later vpi_get_value returning an unexpected string. 99% sure this is a GHDL issue.

Blocked by #3608. I plan on making a `PackedObject` and splitting `LogicObject` into `LogicObject` (for logic scalars) and `LogicArrayObject` (for single dimension logic arrays). `PackedObject` requires `GPI_PACKED_STRUCT` from that commit.

Replace `expect_fail` and `expect_error` with something like `pytest.mark.xfail`

@imphil That sounds better for us. I think we should still do this for something better for users.