osu-replay-parser icon indicating copy to clipboard operation
osu-replay-parser copied to clipboard

Replay offsets if there is a skip at the beginning of the map

Open OlegSuperBro opened this issue 1 year ago • 2 comments

When trying read and write replay with skip at beginning, it offsets. I used this code:

from osrparse import Replay
replay = Replay.from_path("replay_file.osr")
replay.write_path("out.osr")

replay_file.osr works as intended, but out.osr gets offset

OlegSuperBro avatar May 19 '23 23:05 OlegSuperBro

This is a result of the v7.0.0 release.

I hadn't considered that users would expect written replays to preserve the initial break frames. I think @kszlim was right in suggesting we add a parameter to preserve these frames - it's a bit of a sticky situation all around, but the parameter is likely the best solution.

tybug avatar May 20 '23 02:05 tybug

I tried again and now it works fine, I did nothing Edit: Nevermind, it breaks after changing something in replay, but after trying to export the replay even without changes, it breaks

OlegSuperBro avatar May 20 '23 20:05 OlegSuperBro