Konstantinos Stratis

Results 28 comments of Konstantinos Stratis

Thank you @smeijer ! > Regarding the breaking change, there are ways to make the new provider work in the old way, unless a secure option is provided. But do...

@darrenklein I pushed some commits earlier on and addressed a couple of minor issues and comments. Now, regarding the todos you mention: > * The GoogleProvider class no longer needs...

@darrenklein > @kstratis thank you very much for those dev environment instructions, I'm going to try those out a little later this evening. PleasureΒ πŸ™‚! Hope it helps! > What...

Apologies for the delay. I took the liberty of restructuring this PR both to get rid of some bugs and improve its git history. Here's what I did: - Moved...

Hi @smeijer, again, thanks for everything. I thought a bit about your latest feedback and here's my thinking: `src/SearchControl.ts` is effectively user code: User code demonstrating how to use each...

All this time we were trying to load the async geocoder object from within `GoogleProvider`'s constructor. This caused a number of problems which we thought we could solve using one...

Thank you @darrenklein! > if I understand, this will wait to load the script until the first time a user uses the search functionality, is that correct? Exactly. It will...

> I'm currently trying to fix the github action, which keeps complaining about the package-lock πŸš€πŸš€πŸš€ > What do you think of the changes I've pushed? Love where you've taken...

@BruceYuj question is valid. > T[k] can be primitive, and why it doesn't tigger the generic constraint T extends Record? I've got the same question. How is this possible? @sv-98-maxin...

@BruceYuj Turns out the answer to ~your~ our question is this: > [Mapped types](https://www.typescriptlang.org/docs/handbook/2/mapped-types.html) already "skip" primitives by returning the input, and they automatically distribute over union, so you don't...