canvas-api icon indicating copy to clipboard operation
canvas-api copied to clipboard

Document Reader & Writer non-thread-safety

Open Vulcannis opened this issue 6 years ago • 1 comments

Pretty obvious when you look at BaseImpl, but reader & writer instances are not thread safe when using responseCallback, masqueradeAs and masqueradeType. Actually hit this today while testing, figure it would be nice to at least document it for future users.

The quick fix on my end was to use proxies & ThreadLocal to cache instances.

Vulcannis avatar Apr 19 '18 19:04 Vulcannis

Hmm yes that is definitely a problem users should be made aware of. I think we are avoiding it because we use JMS queues for pushing things to Canvas in parallel and each job creates its own writer object. The readme is already pretty sizable but I'll see if I can fit it in somewhere for now.

ToeBee avatar Apr 25 '18 22:04 ToeBee