Kai Sommerfeld

@neo1973 shouldn't this do the trick? ```diff diff --git a/xbmc/interfaces/AnnouncementManager.cpp b/xbmc/interfaces/AnnouncementManager.cpp index abd1ca8c94..ce118cc88c 100644 --- a/xbmc/interfaces/AnnouncementManager.cpp +++ b/xbmc/interfaces/AnnouncementManager.cpp @@ -151,11 +151,14 @@ void CAnnouncementManager::DoAnnounce(AnnouncementFlag flag, { CLog::Log(LOGDEBUG, LOGANNOUNCE, "CAnnouncementManager -...

> because it's destroyed but the copied announcers vector still contains the now invalid pointer. Right. :-/

What about old setting values, stored in existing configurations? Will they still work? Or do they need to be migrated? The change of the type from "int" to "number" seems...

> if you dont find other solution to solve the value migration, the only way could be rename the setting names Yes, at least this should be done. The way...

Sorry, I don't want to be PITA, but shouldn't we try to find and fix the root cause of this problem instead of polluting Kodi code base with workarounds?

> but I am really afraid (see my comments in 19883) that the 'true' fix will be greater than CDateTime one :( Let's do the job right and bite that...

> Matrix users from Turkey already reported this on r/kodi and in Debian. I am OK to hold this for Nexus, but Matrix should be worked around. I do agree.

> If someone has submitted a clang-formatted PR we should never request formatting changes because they used the wrong clang-format version imo. Why not? We also require them to use...

May I suggest to change the commit message to something more meaningful?

> Sure, I can PR that change to the skin. No problem. Will use the tag then. Cool. Thanks guys.