Crop tool does not match selected area

[fabianski7]

To Reproduce Steps to reproduce the behavior:

1. Activate the crop tool and select an area of ​​the image

Screenshots

https://user-images.githubusercontent.com/47755037/123971175-542f0480-d9a9-11eb-9f1f-43c05d9efce5.mp4

Desktop (please complete the following information):

• Ksnip built from master (https://github.com/ksnip/ksnip/commit/339b0b850fff5318e3ccdbd2d12d5c093bc32806)
• KDE Plasma Version: 5.22.2
• KDE Frameworks Version: 5.83.0
• Qt Version: 5.15.2
• Graphics Platform: X11

Additional context Does it look like the cut is made with 2x the previously defined height value?

[DamirPorobic]

Strange, that used to work. Cannot remember changing anything there for the last build.

[DamirPorobic]

I cannot reproduce that on my machine. Do you have scaling or something fancy in your setup? Can you reproduce it with the AppImage? Can you try moving your ksnip config temporary to a different location and try again?

[fabianski7]

Okay, I deleted the ksnip.conf file and tested it again but the problem continued. In the appimage version too

[fabianski7]

same problem on a virtual machine with archlinux + xfce + ksnip 1.9.0

[kpcee]

I can reproduce the bug with Arch Linux, Xfce and ksnip 1.9.0.

[DamirPorobic]

Maybe it's the newer Qt version. I'll try that next.

[felf]

I reported the same issue on bugs.kde.org, because I experienced a wrong “crop experience” in Spectacle’s annotation mode. But I was redirected here. My observation was that cropping was done too eagerly when I confirm the action with the Enter key, but it works as expected when clicking on the Apply button.

When using Enter, the cropping process is called twice. You can see that from the undo history and actually in fabianski7’s video: there are two undo steps. The first returns to the actual selected cropping region, and the second undo returns to the original image.

For reference, here is my original bug report: https://bugs.kde.org/show_bug.cgi?id=462092.