kshramt
kshramt
CI failures addressed and changes ( https://github.com/TanStack/router/compare/fca21d38300ebdc467fe0a2a218c467314ce1522..3dab3613c557c09f5a76447a01e41af568a2b201 ) force pushed.
To clarify, this PR doesn't alter the type definition, but rather makes the existing behavior more explicit (see https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes ).
Setting `"exactOptionalPropertyTypes": true` in the root tsconfig.json will result in many type-check errors like this: ``` src/CatchBoundary.tsx:14:6 - error TS2769: No overload matches this call. Overload 1 of 2, '(props:...
WIP: I am trying to add the flag to `packages/react-router/tsconfig.json` (changing the root `tsconfig.json` seems a bit involved). It seems that https://github.com/TanStack/router/blob/f36f92b459bf0aabbc4d49c1e72c8b2ad6894622/packages/react-router/src/router.ts#L707-L710 may not work well with explicit `undefined`s, as...
Sorry, as enabling `exactOptionalPropertyTypes` turned out to be more complex than I expected, I have rolled back the branch to https://github.com/TanStack/router/pull/2213/commits/7d892ac8ef96a46995b4fff31481f1cc2b6e927a . Since I've already implemented a workaround without this...