kshepherd

Results 59 comments of kshepherd

@tdonohue thanks, yes I'm still working on a few things to push up and then I'll make sure the ITs and style violations are sorted out - we had some...

We had the following note from @abollini regarding functionality and use cases for where and now DOIs can be minted or registered. This has inspired some new changes here, though...

@tdonohue there are some tests still failing with this and the angular PR, as well as some possible tidy-up needed to the way I wired up request GET and POST...

> @kshepherd : Moving this to 7.5 as it won't be possible to review/complete in time for 7.4. Totally understand, thanks for keeping things moving!

This is a great simple script. I've tested it with handles and DOIs in different conditions to understand the results, and the code being 'tested' is really the identifier service...

> So, is this ready to go? I'm +1 as long as we really clearly explain that this will be destructive if run over repositories using `VersionedHandleIdentifierProviderWithCanonicalHandles` - it will...

@J4bbi yep i've given this a +1 so if it looks good to you as well, we can merge

closing and reopening to force new Travis CI build

thanks @tdonohue , I'll get onto the tidy-ups and fixes ASAP and think about the best way forward re: abstraction and making some DOI-specific behaviour more obvious. I agree, the...

@tdonohue I believe I have addressed your concerns here: 1. As per REST Contract discussion, the data model for the identifiers returned in the identifiers REST endpoint has been made...