vim-signature icon indicating copy to clipboard operation
vim-signature copied to clipboard

Display internal marks

Open sanpii opened this issue 10 years ago • 11 comments

Hello,

I have missing something or the internal marks (like '.) are not displayed?

sanpii avatar Feb 26 '14 10:02 sanpii

Sorry, signature doesn't currently support the internal marks. It's on the TODO list but I've been busy with work lately so can't make any promises about when I'll be able to implement it. I think showmarks does though.

kshenoy avatar Feb 26 '14 19:02 kshenoy

+1

nomasprime avatar Apr 12 '15 18:04 nomasprime

@kshenoy would like to have a go at PR for this. Any pointers to get me started?

nomasprime avatar Jan 26 '20 16:01 nomasprime

@nomasprime Tbh, I'd question the value-add of doing this. That's partly why I haven't added this yet. Between vim's internal :marks command and most navigation plugins like CtrlP, Fzf etc. adding support for jumping to marks, I've been wondering if this is really useful. I don't mean to discourage and nor am I against adding support, it's just that I couldn't convince myself that I'd be adding something new.

kshenoy avatar Mar 24 '20 01:03 kshenoy

Ok, I added support for this on the dev_internal_marks. Give it a go and let me know in case of any issues. I'll merge it into the master in a couple of days if everything's hunky-dory.

kshenoy avatar Mar 24 '20 01:03 kshenoy

I add in my vimrc:

let g:SignatureDisplaySplMarks='[]<>"^.(){}'

But I see nothing: 2020-03-24-092651_1676x969_scrot

sanpii avatar Mar 24 '20 08:03 sanpii

@sanpii Oh, sorry about that. I only added it to the LocationList, not the display. I'll get back to you

kshenoy avatar Mar 25 '20 21:03 kshenoy

@kshenoy : Are you working on this? I really would love to see internal marks in the sign column. That way, I would use them more often!

MaxGyver83 avatar Apr 12 '20 08:04 MaxGyver83

Hi @kshenoy. My notifications weren't set up properly, only just saw your reply.

@nomasprime Tbh, I'd question the value-add of doing this. That's partly why I haven't added this yet. Between vim's internal :marks command and most navigation plugins like CtrlP, Fzf etc. adding support for jumping to marks, I've been wondering if this is really useful. I don't mean to discourage and nor am I against adding support, it's just that I couldn't convince myself that I'd be adding something new.

I can't speak for others but I suspect their reasoning's pretty similar: the internal marks are really useful for operations like re-selecting the last visual selection; very hard to keep track of all the internal marks in your head so would be really helpful to see them on the screen before issuing the command; also one less thing to commit to memory, learning curve of Vim's already pretty intense.

For me this has been the one missing feature from all marks plug-ins for a long time. Really glad you've decided to add it, will definitely help distinguish vim-signature from similar projects.

@sanpii Oh, sorry about that. I only added it to the LocationList, not the display. I'll get back to you

Can't say I've ever used them in the location list but I guess it should be applied consistently to wherever other marks are shown.

Really looking forward to trying this out but it's been a long day. Will check it out first thing tomorrow.

PS Probably a good idea to toggle displaying internal marks with a config option and have it disabled by default, imagine some users won't want to see them.

nomasprime avatar Sep 20 '20 00:09 nomasprime

Hello, any updates regarding this? I would love to have this feature, it should definitely help incorporate internal marks into workflow.

deividaspetraitis avatar Mar 02 '21 08:03 deividaspetraitis

+1, these automatic marks indeed are really difficult to keep track of in the head, but incredibly useful if utilized well. would totally make this plugin perfect for me!

stutterrrrer avatar Sep 19 '21 09:09 stutterrrrer