models-web-app icon indicating copy to clipboard operation
models-web-app copied to clipboard

Fix displaying MLFlow predictors

Open rvalkenaers opened this issue 2 years ago • 6 comments

Currently MLFlow predictors cannot be handled by the web app but they are supported by kserve: https://kserve.github.io/website/0.10/modelserving/v1beta1/mlflow/v2/

This PR adds MLFlow to the list of predictor types.

rvalkenaers avatar Sep 13 '23 12:09 rvalkenaers

/assign @yuzisun

rvalkenaers avatar Sep 15 '23 06:09 rvalkenaers

Thanks @rvalkenaers!

/lgtm /approve

kimwnasptd avatar Sep 15 '23 07:09 kimwnasptd

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, rvalkenaers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kserve-oss-bot avatar Sep 15 '23 07:09 kserve-oss-bot

@kimwnasptd

The "Fronted Test / Code format and lint" check is failing but it does not seem to be related to my change:

prettier requires at least version 14 of Node, please upgrade

Is this something you could look into?

rvalkenaers avatar Sep 15 '23 08:09 rvalkenaers

Hello, I am new to KServe and this PR fixes the issue I am currently having with MLflow. Is there any plan to close it in the near future? Thank you!

AlessandroColantonio avatar Feb 05 '24 18:02 AlessandroColantonio

@rvalkenaers could you rebase your PR, now that https://github.com/kserve/models-web-app/pull/77 is merged?

kimwnasptd avatar Apr 29 '24 13:04 kimwnasptd

@juliusvonkohout you can close this PR. Because we merged the PR #96

hansinikarunarathne avatar Sep 15 '24 13:09 hansinikarunarathne