Update Dockerfile.develop
Updated kubebuilder for s390x. I am able to build the developer image successfully on s390x. I have added small snapshot below
[root@m1305001 modelmesh-serving]# make run fmt
make: go: Command not found
which: no controller-gen in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin)
Makefile:216: warning: overriding recipe for target 'fmt'
Makefile:153: warning: ignoring old recipe for target 'fmt'
./scripts/build_devimage.sh "podman"
/usr/bin/sha1sum
Pulling dev image kserve/modelmesh-controller-develop:9f6853f0cc3268cb...
Image kserve/modelmesh-controller-develop:9f6853f0cc3268cb does not exist yet
Building dev image kserve/modelmesh-controller-develop:9f6853f0cc3268cb
[1/2] STEP 1/9: FROM registry.access.redhat.com/ubi8/ubi-minimal:8.9 AS go-toolset
[1/2] STEP 2/9: ARG TARGETOS
--> Using cache b0ca21c485d0f83033c13da6d1311c30e2631ca6e0066f9cf139b82b7b642479
--> b0ca21c485d0
[1/2] STEP 3/9: ARG TARGETARCH
--> Using cache 88086c84e4af70f942ad6a10c0a383e8422f64f13fcfd6b67c83f18045217bb4
--> 88086c84e4af
[1/2] STEP 4/9: ARG GOLANG_VERSION=1.21.6
--> Using cache 0676771de5fa097afebd0a36550778231d56ce13ba4b5a5546d604d0887b1d2e
--> 0676771de5fa
.....
....
[2/2] STEP 28/31: RUN true && go install github.com/onsi/ginkgo/v2/ginkgo && ginkgo version && true
Ginkgo Version 2.13.0
--> 891c5c632c98
[2/2] STEP 29/31: RUN true && go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest && setup-envtest use 1.29 && true
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240516231036-f4ca78ebc00a
go: downloading sigs.k8s.io/controller-runtime v0.18.2
go: sigs.k8s.io/controller-runtime/tools/[email protected] requires go >= 1.22.0; switching to go1.22.3
go: downloading go1.22.3 (linux/s390x)
go: downloading github.com/go-logr/zapr v1.2.4
go: downloading github.com/spf13/afero v1.6.0
go: downloading github.com/go-logr/logr v1.2.4
go: downloading golang.org/x/text v0.12.0
go: downloading go.uber.org/multierr v1.10.0
Version: 1.29.3
OS/Arch: linux/s390x
md5: 6FYdZY5YRV6GoxBEQfc/IQ==
Path: /root/.local/share/kubebuilder-envtest/k8s/1.29.3-linux-s390x
--> b8e38d2752bd
[2/2] STEP 30/31: RUN git config --system --add safe.directory /workspace
--> 8f801c4cf95c
[2/2] STEP 31/31: CMD /bin/bash
[2/2] COMMIT kserve/modelmesh-controller-develop:b6daac75d8d3248c
--> bf58bb0633ef
Successfully tagged localhost/kserve/modelmesh-controller-develop:b6daac75d8d3248c
bf58bb0633efd5a0755374845235ea5542be3090ce0fb2a0493919dc61920835
Image kserve/modelmesh-controller-develop:b6daac75d8d3248c has 62 layers
Tagging dev image kserve/modelmesh-controller-develop:b6daac75d8d3248c as latest
/assign @ckadner
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: modassarrana89
Once this PR has been reviewed and has the lgtm label, please ask for approval from ckadner by writing /assign @ckadner in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I have addressed all the comments . Please review again
@ckadner This PR is not yet merged. It has been already reviewed once as well. Can you please approve the changes