modelmesh-serving icon indicating copy to clipboard operation
modelmesh-serving copied to clipboard

Remove residual "Watson" references

Open njhill opened this issue 2 years ago • 7 comments

Model-mesh was originally developed as part of IBM Watson. Now that it is part of KServe we should scrub any remaining places that "watson" is used in the codebase, at least starting with those that are straightforward to change.

njhill avatar Dec 14 '22 23:12 njhill

Hi Nick @njhill , does this issue include changing package names in proto files from "com.ibm.watson" to may be "io.kserve" ?

ScrapCodes avatar Jan 05 '23 10:01 ScrapCodes

@ScrapCodes apologies for missing your message here originally. Yes I think that would be good, though I'm actually not sure whether KServe owns the kserve.io domain. We shouldn't change the proto package itself but the package for generated java stubs should be fine to change.

I would suggest holding off on changing the java package of the rest of the modelmesh code for now, let's just cover other less invasive things first, like directory names within the container, etc. Then we can do the java package renaming in a second pass.

njhill avatar Jan 18 '23 23:01 njhill

This looks like a good first issue to start contributing to this project. I joined the open-source programme @ IBM and have @rafvasq mentoring me for contributions to this project. I am interested in this project as ML workflows are an area of interest, from studying and focusing on it at university.

Giles-Billenness avatar Feb 27 '23 15:02 Giles-Billenness

@Giles-Billenness You are welcome, to work on it! /assign @Giles-Billenness

ScrapCodes avatar Feb 27 '23 16:02 ScrapCodes

Hello, Is this issue complete? If not I'd also like to take this or another similar issue. @rafvasq @Giles-Billenness @ScrapCodes

AshleyZhao avatar May 15 '23 17:05 AshleyZhao

Hey @AshleyZhao, thanks for the interest! I believe @Giles-Billenness is looking into this but had the obstacle M1 chip support which was only introduced in the past few days or so. Let's see if Giles confirms he still has time to look at this before you take it on.

rafvasq avatar May 15 '23 17:05 rafvasq

Hey, thanks for the update. I will be taking a look at this again given the hardware support

Giles-Billenness avatar May 16 '23 14:05 Giles-Billenness