Kai Sassnowski

Results 105 comments of Kai Sassnowski

Ok, I'm able to reproduce this and understand what the issue is. Unfortunately, it looks like this is not something I can fix before this PR gets merged into PHPStan...

I'm unable to reproduce this. Can you set up a small repository that illustrates the bug? What queue connection are you using and how are you starting the workflow?

Yes, all jobs in a workflow should implement this interface. Jobs that don't implement the interface are deprecated and are only kept around for BC reasons support for them will...

I haven't tested this yet, but I would assume that marking the job as gated inside the job's own `handle` method won't work. Because once the `handle` method finishes without...

I think what we should do is change [this line](https://github.com/ksassnowski/venture/blob/master/src/WorkflowEventSubscriber.php#L54) in the `WorkflowEventSubscriber` to check for `$event->job->isDeletedOrReleased()` instead. I'm happy to accept a PR for that. This way, you would...

That being said, I'm just writing this off the top of my head. I haven't actually tested this. So it's probably worth it to verify that my suggestion actually works...

Ok, so there's a couple things going on. First of all, I linked the wrong line in the `WorkflowEventSubscriber` since that part of the code is dealing with the `JobProcessed`...

After digging into this a little more, I'm not sure if this is even possible to implement, unfortunately. Once a job has been dispatched, there are only limited ways in...

I just thought of something that _could_ potentially work, although I haven't tested it yet. We could check ourselves if the job was deleted after we fire our own `JobProcessing`...

> but from Venture's perspective, even the gated job is marked as finished Yes, because there is no way for us to tell if a job was "aborted" or finished...