Sankeerthan Kasilingam

Results 61 comments of Sankeerthan Kasilingam

> Hey @shankeerthan-kasilingam, we'd be happy to help you with contribution questions. We have some documentation on contributing that should be a helpful starting point: https://docs.dolthub.com/guides/contributing > > Feel free...

Hi @discordianfish, Hope you're well! Can I send a PR for this? Will you be able to review? Thanks!

> @ksankeerth yes! Feel free to assign the PR to me I opened a PR in procfs. https://github.com/prometheus/procfs/pull/487 Please check. Once it's merged, I'll send a PR to node_exporter. Thanks

@KelvinTanJF, PR for procfs got merged recently https://github.com/prometheus/procfs/pull/487. I think, PR for this node_exporter can be merged after review.

Build and tests failed because of missing field in struct. Once we merge procfs PR, I guess these errors won't come.

Hi Team/ @discordianfish, Since this PR is merged https://github.com/prometheus/procfs/pull/487, Can you please run CI again?

> @ksankeerth Looks like this still needs work Sorry for missing this. I'll update tonight

It seems, there are some e2e test failures. I'm looking at them.

Hi @discordianfish / @SuperQ , I tested locally and can see NFS mountstats that I've added. But e2e tests fail because of old fixtures. Can You help me to update...

Hi Team, Updated PR with required changes. Please check and let me know if more changes have to be done. Thanks