KS. Yim comments

Results 29 comments of


                                            KS. Yim

Add JSON5 support

@minwoox Oops, my mistake 🤣. Reopened the PR! Looking forward to the rework!

Generate Kotlin DSL builder for protobuf messages

Did some tests, and the right way to add `kotlin` plugin would be the following. The original approach emits a warning. ```groovy generateProtoTasks { all().forEach { it -> it.plugins {...

Add `CreationMode` for annotated service dependencies

There are several things that I am concerned of with this PR and want to get some advice from maintainers. 1. Regression) The dependencies added by their default constructor are...

Argocd image updater stuck on specific tag - not updating .argocd-source-myapp.yaml unless tag is deleted from docker registry

Would you please compare the build timestamp of those 2 images? The documentation about the `latest` update strategy says: > It is important to understand, that this strategy will consider...

Argocd image updater stuck on specific tag - not updating .argocd-source-myapp.yaml unless tag is deleted from docker registry

@dren-sokoli What tool do you use to build an image in Azure DevOps pipeline? `name` strategy will work just fine if your image tags' number part is correctly padded, I...

level=info msg="Processing results: applications=3 images_considered=3 images_skipped=0 images_updated=0 errors=0"

Q. Did you define separate ArgoCD Application resources for dev and staging?

Option to just restart pod on image update detection

Though I am not the maintainer of this project, your best bet is to use [digest](https://argocd-image-updater.readthedocs.io/en/stable/basics/update-strategies/#strategy-digest) update strategy which is introduced exactly for this purpose (restarting a pod upon an...

Make `defaultUseHttp2Preface` flag more explicit

Hi, I'd like to work on a PR for this, but I'd like to confirm the following point before I start working on this. Would there be a real or...

Huge performance gap of `JwtPublicKeyVerify` depending on the key within a keyset used for signature generation

@tholenst Thanks for suggesting alternative ways. It looks like not parsing the token before signature verification is a design decision as stated in [JWT-HOWTO.md](https://github.com/google/tink/blob/master/docs/JWT-HOWTO.md)? Would you mind me having a...