KS. Yim

Results 29 comments of KS. Yim

@minwoox @ikhoon Question about the merge process. Should I apply the same change manually to Armeria first and send a PR there first? Updates: I haven't read @ikhoon's comment carefully....

It seems impossible to upgrade `ktlint` version without re-formatting many kotlin code in Armeria. Testing the change in https://github.com/line/armeria/pull/4488.

@minwoox I can start working on this after a few days (maybe this weekend๐Ÿ˜Š). Let me handle this.

@minwoox Thanks for the advice. I will check if that works and send a fix PR!

@jrhee17 @ikhoon @minwoox I've re-written the PR as per your advices, PTAL ๐Ÿ™. * Use `EntryType.JSON` for JSON5 * Use dedicated mapper for JSON5 * Give higher priority to `contentAsText`...

@minwoox I've resolved most of your comments except the feature of not notifying watchers for any changes that does not affect the actual content of JSON5. And I added a...

@minwoox Thanks for the patience. It seems Jackson's `ALLOW_BACKSLASH_ESCAPING_ANY_CHARACTER` feature doesn't work well in `Windows`..? I should test it in my Windows laptop.

Let me handle this issue ๐Ÿคš.

@jyterencekim No ๐Ÿ˜ญ. Stopped working on this for now. You can take this issue if you want.. Just some notes tracing back an old memory.. This PR somewhat has achieved...

@minwoox thanks you for all the valuable feedback you gave while I am working on this ๐Ÿ˜„. Closing this PR in favor of API v2.