isAtEnd implementation is the inverse of how NSScanner works

[FergalMohan]

I think that isAtEnd should really be opposite of the way it is implemented to conform with how NSScanner is implemented i.e.

• (BOOL)isAtEnd { return (self.offset >= self.data.length); }

[krzyzanowskim]

Pull Request with some tests?

[FergalMohan]

Hi Marcin, I'm not familiar with exactly how ? Do I make a Pull Request and then make the change with a corresponding Unit Test so that you can review ? Fergal

[krzyzanowskim]

yes, please

[FergalMohan]

Hi Marcin, I did that just now, sorry about the delay.Fergal From: Marcin Krzyzanowski [email protected] To: krzyzanowskim/MKDataScanner [email protected] Cc: FergalMohan [email protected] Sent: Sunday, October 11, 2015 6:31 PM Subject: Re: [MKDataScanner] isAtEnd implementation is the inverse of how NSScanner works (#2)

yes, please— Reply to this email directly or view it on GitHub.

[FergalMohan]

Hi Marcin, is there something that needs to be done to the PodSpec to make these latest changes available when a "pod update" is done ? Fergal