CryptoSwift icon indicating copy to clipboard operation
CryptoSwift copied to clipboard

Published 20 hours ago • verified publisher icon krzyzanowskim

fix pkcs7padding error

Open rakeyang opened this issue 3 years ago • 3 comments

Fixes #

Checklist:

  • [ ] Correct file headers (see CONTRIBUTING.md).
  • [ ] Formatted with SwiftFormat.
  • [ ] Tests added.

Changes proposed in this pull request:

rakeyang avatar Aug 31 '21 09:08 rakeyang

Is it linked to #865?

nathanfallet avatar Aug 31 '21 09:08 nathanfallet

@rakeyang do you mind elaborate about this change? testcase that trigger the issue for you is every much welcome. What is padding is 1?

krzyzanowskim avatar Aug 31 '21 10:08 krzyzanowskim

do you mind elaborate about this change? testcase that trigger the issue for you is every much welcome. What is padding is 1?

sorry i forget this pull request.

the detail information at: https://en.wikipedia.org/wiki/PKCS_7

rakeyang avatar Jan 18 '22 02:01 rakeyang

I don't think this is a change we should merge in. I'm happy to back to discussion if provided more information behind the reasoning of the change.

krzyzanowskim avatar Sep 17 '22 15:09 krzyzanowskim