CryptoSwift icon indicating copy to clipboard operation
CryptoSwift copied to clipboard
verified publisher icon krzyzanowskim

Added Salsa20 cipher and simplified ChaCha20

Open rogerxaic opened this issue 6 years ago • 5 comments

Checklist:

  • [x] Correct file headers (see CONTRIBUTING.md).
  • [x] Formatted with SwiftFormat.
  • [x] Tests passed.

Changes proposed in this pull request:

  • The Salsa20 algorithm has been added
  • The ChaCha20 algorithm implementation is simplified

rogerxaic avatar Apr 16 '19 08:04 rogerxaic

What is runtime performance difference?

krzyzanowskim avatar Apr 16 '19 12:04 krzyzanowskim

I've got an average difference of 26ms on iOS and 35ms on Mac. Both quicker than the previous implementation.

rogerxaic avatar Apr 16 '19 13:04 rogerxaic

@rogerxaic By how many percent?

Sajjon avatar Apr 23 '19 14:04 Sajjon

Between 2 and 3 percent if I recall correctly.

rogerxaic avatar Apr 24 '19 18:04 rogerxaic