capistrano-getservers icon indicating copy to clipboard operation
capistrano-getservers copied to clipboard

use the variables for AWS access credentials rather than the ENV variabl...

Open techlunacy opened this issue 10 years ago • 5 comments

allows the user to set the aws credentials in the deploy.rb file as such: set :aws_access_key_id, "XXXXXXXXXXXXXXXXXXXXXXX" set :aws_secret_access_key, "XXXXXXXXXXXXxXXXXXXXXXXXXX"

techlunacy avatar Mar 04 '14 03:03 techlunacy

I think it would be best if it checks for local variables and fallback to ENV.

antonbabenko avatar Oct 16 '14 21:10 antonbabenko

I'm in favor of such a change. Would @techlunacy care to ammend the code?

aws_secret_access_key: fetch(:aws_secret_access_key) || ENV['AWS_SECRET_ACCESS_KEY']
aws_access_key_id: fetch(:aws_access_key_id) || ENV['AWS_ACCESS_KEY_ID']

If not I can just edit the code and push that up. I'll give'em until Monday, Oct 20.

kryptek avatar Oct 16 '14 23:10 kryptek

i would have thought these lines (on 15/16) would have handled what you are asking for in this situation

_cset(:aws_secret_access_key, ENV['AWS_SECRET_ACCESS_KEY'])         

_cset(:aws_access_key_id, ENV['AWS_ACCESS_KEY_ID'])

if not i will add what you are asking

techlunacy avatar Oct 17 '14 02:10 techlunacy

Ahh.. yeah, sorry about that. @techlunacy.

In this case, @antonbabenko , you would explicitly set your keys in deploy.rb to something else if you didn't want ENV defaults..

kryptek avatar Oct 17 '14 07:10 kryptek

ok, point taken :) Thanks.

antonbabenko avatar Oct 17 '14 07:10 antonbabenko