capistrano-getservers
capistrano-getservers copied to clipboard
use the variables for AWS access credentials rather than the ENV variabl...
allows the user to set the aws credentials in the deploy.rb file as such: set :aws_access_key_id, "XXXXXXXXXXXXXXXXXXXXXXX" set :aws_secret_access_key, "XXXXXXXXXXXXxXXXXXXXXXXXXX"
I think it would be best if it checks for local variables and fallback to ENV.
I'm in favor of such a change. Would @techlunacy care to ammend the code?
aws_secret_access_key: fetch(:aws_secret_access_key) || ENV['AWS_SECRET_ACCESS_KEY']
aws_access_key_id: fetch(:aws_access_key_id) || ENV['AWS_ACCESS_KEY_ID']
If not I can just edit the code and push that up. I'll give'em until Monday, Oct 20.
i would have thought these lines (on 15/16) would have handled what you are asking for in this situation
_cset(:aws_secret_access_key, ENV['AWS_SECRET_ACCESS_KEY'])
_cset(:aws_access_key_id, ENV['AWS_ACCESS_KEY_ID'])
if not i will add what you are asking
Ahh.. yeah, sorry about that. @techlunacy.
In this case, @antonbabenko , you would explicitly set your keys in deploy.rb to something else if you didn't want ENV defaults..
ok, point taken :) Thanks.