sigchain icon indicating copy to clipboard operation
sigchain copied to clipboard

Build warnings, use of deprecated function

Open ghost opened this issue 6 years ago • 1 comments

I'm currently using the latest nightly, and I'm getting these warnings on build:

warning: unused import: `self::users::get_user_by_name`========> ] 208/211  
  --> sigchain_client/src/krd_client/mod.rs:18:5
   |
18 | use self::users::get_user_by_name;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

warning: unused import: `self::users::os::unix::UserExt`
  --> sigchain_client/src/krd_client/mod.rs:19:5
   |
19 | use self::users::os::unix::UserExt;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
  --> sigchain_client/src/krd_client/mod.rs:31:21
   |
31 |     let home_path = env::home_dir();
   |                     ^^^^^^^^^^^^^
   |
   = note: #[warn(deprecated)] on by default

I'd like to have a look at fixing these if that's ok?

ghost avatar Jul 17 '18 10:07 ghost

Sure, thanks for reporting them!

kcking avatar Jul 17 '18 19:07 kcking