Vikash comments

Results 45 comments of


                                            Vikash

Fix iceberg $files metadata table not show delete files

@0xffmeta FYI https://github.com/trinodb/trino/pull/16519/files

Fix iceberg $files metadata table not show delete files

Hi @0xffmeta, https://github.com/trinodb/trino/pull/16519 is merged now. Could you please rebase and resolved the conflicts?

Fix iceberg $files metadata table not show delete files

@0xffmeta, Sorry for the late response. Overall LGTM. @alexjo2144 Could you please take a look?

Introduce parallelism in Iceberg `migrate` procedure

Thanks @findinpath | @ebyhr for the review. I have addressed the comments.

Introduce parallelism in Iceberg `migrate` procedure

CI hits https://github.com/trinodb/trino/issues/12818

Use record-cursor based implementation in Iceberg system tables

Rebased and resolved conflicts.

Classify Iceberg CommitFailedException as TRANSACTION_CONFLICT #16770

@cla-bot check

Flaky test TestHiveCoercionOnUnpartitionedTable.testHiveCoercionParquet: incorrect results

@findepi, I tried locally but not able to repro the issue. As per the stacktrace, The failure is happening when running query on Hive engine. ``` at io.trino.tests.product.hive.BaseTestHiveCoercion.doTestHiveCoercion(BaseTestHiveCoercion.java:209) ``` ```...

Add storage api support for reading table for query function in bigquery

Hi @ebyhr, I tried running query on `lineitem` table which has 60175 rows. Here is the observation that 1. WIth `STORAGE_API` approach we get better performance than `REST_API` when the...

Add storage api support for reading table for query function in bigquery

I am trying to see the possibility to use of `QueryStage#shuffleOutputBytes`. This value is populated only when the native query has been executed. Once the query has been executed then...