xpano icon indicating copy to clipboard operation
xpano copied to clipboard

ERR PANO TOO LARGE

Open 18702738101 opened this issue 3 months ago • 7 comments

When I export a panoramic picture, the software reports an error: ERR PANO TOO LARGE Reset the adjustments through the edit menu. 微信图片_20240312162017

18702738101 avatar Mar 12 '24 08:03 18702738101

I can confirm issiue with ERR PANO TOO LARGE for 10+ JPEG photos. Did not run out of memory. I wouldnt mind if pano from multiple photos took long to export

przestaw avatar Mar 14 '24 15:03 przestaw

Thanks for the reports!

Just to confirm, did you get a good result with a previous version of Xpano, or is this the first time you're testing the app now with the 0.18 version? I have added this check in 0.18 because previously the app was crashing for large panos.

I'll have a look and try to implement it so that the pano is exported at a maximum supported resolution (possibly selectable in the options).

If you don't mind sharing your pictures, I'd be happy to test the new approach on them, you can send me a link on email / matrix chat (links on https://krupkat.cz)

krupkat avatar Mar 14 '24 18:03 krupkat

I have added this check in 0.18 because previously the app was crashing for large panos.

Is this limitation of OpenCV or some engine in the app? I admit my photos were JPEGS ~18MPx each straight from camera with no edits [I was testing if your app will suit my needs].

If this is limitation of the app, please point me to the parts of code/module responsible for holding/handling of stiched panorama. Any information about algorithm/architecture of your app will be welcome. I have no familiarity with OpenCV API [or GUI you have used] but I have some experience with bitmaps & graphics in boost/Qt soo... when I will have some free time I might try to help :)

Cheers

przestaw avatar Mar 15 '24 18:03 przestaw

I also encountered this issue, just made this PR https://github.com/krupkat/xpano/pull/129 that makes the maximum panorama size customizable. This should at least help a little bit :)

Altonss avatar Apr 23 '24 08:04 Altonss

This is great, thanks a lot! :)

@przestaw

Is this limitation of OpenCV or some engine in the app?

The error was coming from OpenCV, but honestly I was not able to reproduce it when I tried recently... when I disable the max pano size and try some large pano (e.g. by rotating a perspective projection in so that it stretches a lot) I get an out of memory exception and surprisingly, the app survives, just cancelling the task.

krupkat avatar Apr 23 '24 18:04 krupkat

On some panorama settings (perspective for example), I also get OOM errors from Opencv (but the app doesn't crash!). But using spherical everything works fine. I guess this might be related to how the images have been taken (more suited to spherical), but it's still strange that perspective needs so much more memory.

Altonss avatar Apr 28 '24 17:04 Altonss