DA is throwing repeated error messages for layer config yaml with step value zero

[shruacha1234]

DA is throwing repeated error messages for layer config yaml with step value zero

Actual error message

com.autotune.dependencyAnalyzer.exceptions.InvalidValueException: Tunable step cannot be 0Tunable step cannot be 0Tunable step cannot be 0

Expected error message

com.autotune.dependencyAnalyzer.exceptions.InvalidValueException: Tunable step cannot be 0

layer config yaml

apiVersion: "recommender.com/v1"
kind: "AutotuneConfig"
metadata:
  name: "zero-step"
layer_name: container
layer_level: 0
details: generic container tunables
layerPresence:
  # This layer is assumed to be available by default for all applications.
  presence: always
tunables:
- name: memoryRequest
  value_type: double
  upper_bound: 300
  lower_bound: 150
  step: 0
  queries:
    datasource:
    - name: 'prometheus'
      query: 'container_memory_working_set_bytes{$CONTAINER_LABEL$="", $POD_LABEL$="$POD$"}'
  sla_class:
  - response_time
  - throughput
  - resource_usage

- name: cpuRequest
  value_type: double
  upper_bound: 3.0
  lower_bound: 1.0
  step: 0.01
  queries:
    datasource:
    - name: 'prometheus'
      query: '(container_cpu_usage_seconds_total{$CONTAINER_LABEL$!="POD", $POD_LABEL$="$POD$"}[1m])'
  sla_class:
  - response_time
  - throughput
  - resource_usage

[shmarsy]

hello, I am beginner and i want to contribute in this issue.

[chandrams]

@shmarsy Hi, Sure, you can get started by going through the contributing.md You can also join our slack channel (link is in the contributing.md)

[shreyabiradar07]

Hi @chandrams - To reproduce this issue, I ran the required tests and the tests passed for zero-step value while failed for no-step-value/null-step. I was wondering if this validation is correct for zero-step?

Attaching the test zip folder with log file test_step_value.zip

[chandrams]

@shreyabiradar07 - I think the issue reported is the below repeated message. You can find this in zero-step-autotune.log in the zip you have attached.

com.autotune.analyzer.exceptions.InvalidValueException: Tunable step cannot be 0 or nullTunable step cannot be 0 or nullTunable step cannot be 0 or null

[shreyabiradar07]

Hi @chandrams - I have fixed the repeated error messages issue for the zero-step-value testcase. Attaching the zero-step-autotune.log file tested using the docker image docker.io/shbiradar/zero_step_value:tunable

zero-step-autotune.log testcase_step.zip