Tim Kretschmer

Results 66 issues of Tim Kretschmer

Since Spree 3.x now supports the current_store the Store should have_many :pages. I can make the pull request.

we have a quite complex subdomain logic and thus multiple distributions that we need to expire while deploying or build. there is no `distribution-ids: ["1", "2", "3"]` which could have...

like disabling or enabling 2FA for example should require current OTP on controller level. couldn't find any helpers ``` def activate_two_factor **otp_required!** current_user.update_attributes(setting_params) end ``` something like that?

enhancement

https://github.com/tinfoil/devise-two-factor/pull/144 however if i run rake i get following errors. i changed the models in the test - include ::ActiveModel::Validations::Callbacks + include ::ActiveModel::Validations but that doesn't fix the issue. can...

help wanted
question

rather than `false` maybe `raise OTPAlreadyConsumed` would be better? In this case we could tell the user exactly why his login didn't worked. example: user needs to whitelist his IP...

question

checking an OTP to perform update method on the model ``` u = User.first u.update_with_otp(secure_field: true, otp_attempt: 123456) # => false u.errors # @details={:otp_attempt=>[{:error=>:invalid}]}, # @messages={:otp_attempt=>["is invalid"]}> ``` ~~now the...

enhancement

pull request for https://github.com/tinfoil/devise-two-factor/issues/147

``` /usr/local/rvm/gems/default/gems/origami-2.1.0/lib/origami/string.rb:416: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call /usr/local/rvm/gems/default/gems/origami-2.1.0/lib/origami/string.rb:373: warning: The called method `initialize' is defined here /usr/local/rvm/gems/default/gems/origami-2.1.0/lib/origami/string.rb:436:...