Fix: #2113: ensure that filter handler does not leak opaque requests/responses if the upstream or downstream side closes

[k-wall]

Type of change

Select the type of your PR

• Bugfix

Description

Fix: #2113: ensure that filter handler does not leak opaque requests/responses bytebufs if the upstream or downstream side closes whilst requests/responses are queued-up (auto-read toggled off).

I'm not convinced that this is actually the root cause of #2113 (I haven't been able to reproduce the issue), but I think you can reason that the FilterHandler code is leaky/wrong.

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• [ ] PR raised from a fork of this repository and made from a branch rather than main.
• [ ] Write tests
• [ ] Update documentation
• [ ] Make sure all unit/integration tests pass
• [ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
• [ ] If applicable to the change, trigger the system test suite. Make sure tests pass.
• [ ] If applicable to the change, trigger the performance test suite. Ensure that any degradations to performance numbers are understood and justified.
• [ ] Ensure the PR references relevant issue(s) so they are closed on merging.
• [ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

NOTE: You must be a member of @kroxylicious/developers to trigger the system test and performance test suites. If you are not part of this group, comment on the PR requesting a trigger, tagging @kroxylicious/developers.

[k-wall]

I'm not proposing to chase the additional coverage in this PR. Those were already uncovered paths.

[SamBarker]

Happy to merge without fixing the coverage issues.

[sonarqubecloud[bot]]

Quality Gate failed

Failed conditions
61.1% Coverage on New Code (required ≥ 76%)

See analysis details on SonarQube Cloud