[System Tests] why is our test impl validating if alias exists when deleting the KEK

Open franvila opened this issue 1 year ago • 1 comments

I appreciate this is just moved code, but why is our test impl validating this? Shouldn't we just forward it to the backend and let it decide? As currently we aren't actually testing against what the real KMS's systems will do when asked to delete an unknown alias.

Originally posted by @SamBarker in https://github.com/kroxylicious/kroxylicious/pull/1367#discussion_r1687171645

Jul 23 '24 10:07 franvila

Currently we have some functionality included in the deleteKek method in the TestKekManager implementations that would not allow us to test the behavior of the KMS in case of an intended error, such as deleting a non-exisiting alias/keyId. So we could think about moving that functionality to the test behavior instead having it inside the framework.

Jul 24 '24 09:07 franvila