tachyon icon indicating copy to clipboard operation
tachyon copied to clipboard

Potential bug: Fix not to allow different types for template parameters

Open fakedev9999 opened this issue 1 year ago • 0 comments

IMO, as what I've suggested in this comment, https://github.com/kroma-network/tachyon/pull/206#discussion_r1433621456.

template <typename Domain, typename Poly,
          typename Evals = typename Domain::Evals, typename F>
Evals CoeffToExtendedPart(const Domain* domain, const Poly& poly, const F& zeta,

this kind of code would be more correct to be written as below.

template <typename Domain>
typename Domain::Evals CoeffToExtendedPart(const Domain* domain, const typename Domain::Poly& poly, const typename Domain::Field& zeta,

fakedev9999 avatar Dec 21 '23 09:12 fakedev9999