Bernardo Ramos

Results 218 comments of Bernardo Ramos

@hayarobi should this PR be based/merged onto the `release/2.4.4` branch?

This lacks regression tests for computed gas

Show an example of output when using the above command And the normal output so we can compare

@hayarobi this can be merged if it is ready

TODO: the tests must be run for all the hardfork versions

PROBLEM: it is giving difference in gas on V4 when new functions are added to the module If we comment the lines that add the new functions, it gives the...

The mempool will need a way to get the total number of approved participants from the contract, or the considered "majority" for that case (it can be half +1, 2/3,...

The contract can have logic to delete the internal used state once the majority is reached. So if all the transactions are processed in a single block (best-case scenario) no...

### Corner cases -> The contract has more than 1 pending requests, so maybe the incoming txns are not related... _a. to solve this, maybe the engine should be able...

Another option: The contract can have a verifier function that can be executed by the mempool, before the tx execution. (Aergo already has a similar thing for the fee delegation...