Johannes Altmanninger

that seems like an inconvenient way to propagate `$?`. Take a look at `rc/tools/format.kak` for an alternative method.

> But there is a point where, if the tests are similar enough, it would be a lot of code duplication maybe extract test logic into a test-only function and...

Might be worth checking if LLVM's FileCheck tool supports something similar. My guess is no, because in LLVM the test driver (`lit`) is independent of `FileCheck`, so you can solve...

> Running: sh -c 'env HOME=$(mktemp -d) XDG_CONFIG_HOME= XDG_DATA_DIRS= fish' followed by fish_vi_key_bindings still reproduces the bug. On 3.7.1 it's also necessary to run something like ` set fish_cursor_insert line`...

oh right, fish used to do user agent ($TERM) sniffing here. That's gone in the next release.

On systems like Debian there is no need for `col` because if stdout is not a TTY (e.g. `man printf | cat`) then man will implicitly pipe its output to...

> &raw const can't be used on temporary values I wonder why not, since it seems to work fine with the cast version (`let _ptr = &42f32 as *const f32;`)....

There's still new code duplication (`Some(DiagnosticSeverity::HINT) => "DiagnosticHint",`), the commit does several unrelated things (it should be split into at least two since the typo fix is unrelated). The above...

yeah either use the function-return trick or do what the virtualenv prompt does: ```fish functions --copy fish_prompt __flox_wrapped_prompt function fish_prompt set -l original_prompt (__flox_wrapped_prompt) ... printf %s\n $original_prompt end ```

> The virtualenv method seems to mess up newlines: Either use set -l prompt (__flox_wrapped_prompt | string collect --no-trim-newlines) which preserves all newlines. Or deal with it in another way...