Johannes Altmanninger

ah the fix is definitely valid for some configurations, we also hit it in https://github.com/fish-shell/fish-shell/issues/11004#issuecomment-2571494782 will add the fallbacks for now, also in master, (reducing differences reduces confusion)

this is what I'll apply to both branches (will wait for a few days in case we find new information) ```patch Date: Sat, 1 Mar 2025 16:27:59 +0100 Subject: [PATCH]...

> Then pressed alt+right in fish_key_reader > > ``` > fish_key_reader -V > Press a key: > # decoded from: \e\[C > bind right 'do something Are you absolutely sure...

> for now I was using hotfix mentioned above); then opened a new tab, the issue became present again sounds like your new tab executed the wrong fish binary, since...

Please test, with your iTerm config, for commit in 303af07~ 303af07 git checkout $commit && cargo b && fish_features= target/debug/fish_key_reader -V end and after both "Press a key" prompts, press...

Based on what I know I don't really understand how the benefits of adding a timeout would outweigh its drawbacks. I didn't comment yet because that would take a lot...

ugh I accidentally overwrote the commit message. Also I'm seeing an issue where enter doesn't move to the next line (seems like an off-by-one-error). I can consistently reproduce by typing...

Thanks that works but I wonder why we need to reset the line (e.g. emit `\r` here). Can we remove it? Tested with this prompt. Maybe there is an issue...

On Mon, Apr 14, 2025 at 02:16:12AM -0700, kerty0 wrote: > kerty0 left a comment (fish-shell/fish-shell#11153) > > > Thanks that works but I wonder why we need to reset...

On Tue, Apr 15, 2025 at 09:13:26AM -0700, kerty0 wrote: > kerty0 left a comment (fish-shell/fish-shell#11153) > > > Your other diff about `cursor_is_wrapped_to_own_line()` might be useful for empty prompts,...